tests: spi_loopback: Fix high RAM usage #72895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes zephyrproject-rtos#72792. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
teburd
approved these changes
May 16, 2024
rlubos
approved these changes
May 20, 2024
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 21, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 22, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 22, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 23, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 25, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
May 27, 2024
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Upstream PR: zephyrproject-rtos/zephyr#72895 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
tbursztyka
approved these changes
May 29, 2024
henrikbrixandersen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures.
So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM.
Fixes #72792.