Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kconfig: build system ignores configs for snps/nsim SoCs after HWMv2 was applied #72793

Open
kokas-a opened this issue May 15, 2024 · 1 comment
Assignees
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug HWMv2 priority: medium Medium impact/importance bug

Comments

@kokas-a
Copy link

kokas-a commented May 15, 2024

Describe the bug
After HWMv2 model was applied, build system ignores config XIP that configured on SoC level of Kconfig.

Synopsys nSIM platforms has following levels of XIP configs:

  1. arch/Kconfig applied for ARC architecture in general via imply XIP
  2. soc/snps/nsim/Kconfig.defconfig via default n
  3. (optional) board/snps/nsim/ ${board}_defconfig

If XIP configuration is not set on board level explicitly, then 2nd level (SoC-level) config is also skipped. And final configuration is taken from arch-level via imply XIP and assigned with XIP=y value.

To Reproduce
Steps to reproduce the behavior:

  1. west build -b nsim/nsim_em samples/hello_world
  2. cat build/zephyr/.config | grep XIP
  3. See incorrect behavior: CONFIG_XIP=y

Expected behavior
CONFIG_XIP=n in .config file, as config XIP was not explicitly defined on board level. It defined with n value on SoC level.

Environment (please complete the following information):

  • OS: LInux
  • Toolchain: Zephyr SDK, ARCMWDT
  • Commit SHA ff58bd0 or just main
@kokas-a kokas-a added the bug The issue is a bug, or the PR is fixing a bug label May 15, 2024
@kokas-a
Copy link
Author

kokas-a commented May 16, 2024

The issue touches not only ARC nSIM platforms. For example, tlsr9518adk80d board has the same way of including XIP configs, and final result is CONFIG_XIP=y despite it turned off on SoC level.

@nashif nashif added the priority: medium Medium impact/importance bug label May 21, 2024
kokas-a pushed a commit to kokas-a/zephyr that referenced this issue May 28, 2024
Workaround for zephyrproject-rtos#72793.
Because of pointed issue CONFIG_XIP should be defined explicitly.

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
dleach02 pushed a commit that referenced this issue May 30, 2024
Workaround for #72793.
Because of pointed issue CONFIG_XIP should be defined explicitly.

Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this issue May 31, 2024
Workaround for zephyrproject-rtos/zephyr#72793.
Because of pointed issue CONFIG_XIP should be defined explicitly.

(cherry picked from commit 03b2767)

Original-Signed-off-by: Nikolay Agishev <agishev@synopsys.com>
GitOrigin-RevId: 03b2767
Change-Id: I0e02c8a30e297765f0aca92f42423e6ab19c9930
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5588603
Tested-by: Tristan Honscheid <honscheid@google.com>
Reviewed-by: Tristan Honscheid <honscheid@google.com>
Commit-Queue: Tristan Honscheid <honscheid@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug HWMv2 priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants