-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: http: HTTP server send incomplete response header #72887
Comments
Hi @mustafaabdullahk! We appreciate you submitting your first issue for our open-source project. 🌟 Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙 |
@mustafaabdullahk Is there an easy way to replicate the issue? To me it looks like we might run out of network buffers at some point. Are you running plain http_sample as you seem to have the prometheus support enabled. What does your prj.conf file look like? |
@jukkar Can be used mustafaabdullahk:mustafaabdullahk/prometheus-library branch directly. I did use samples/net/sockets/http_server prj.conf just one diff. I did add just CONFIG_PROMETHEUS.
|
I took your branch and I am assuming you mean the |
Thanks, I could replicate the issue, investigating... |
Your welcome, i apply some patch for solve issue and working. If you want to i create pull request for that, I can. |
The chunked response was not sent properly. There were extra "\r\n" before the chunk lenght and the length of the string to be sent was calculated incorrectly. Fixes zephyrproject-rtos#72887 Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Thanks, I fixed it before I saw your offer. Anyway, please try the PR and see if it works for you. |
The chunked response was not sent properly. There were extra "\r\n" before the chunk lenght and the length of the string to be sent was calculated incorrectly. Fixes #72887 Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Describe the bug
I have one problem about http response header. When i was trying to last changes to http server, i face to response header length problem. i did save the screen following issue:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Impact
HTTP request finish by fail (error encoding chunk).
Logs and console output
Environment (please complete the following information):
Additional context
that block maybe contain strlen bug:
The text was updated successfully, but these errors were encountered: