-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of twister errors in CI that don't get reported as failures #72807
Comments
I found the root cause of this. Will provide a fix soon |
the above link fixes "unit" type tests. Next PR will fix the exception handling so such errors are correctly reported |
what next PR? where is it? |
WIP. Probably won't be able to push it today. The error with failing test is fixed. IMO failing unit tests were high priority. However, the fact that twister was not able to properly handle those issue is not that high, especially that this was already like this and the recent unit test errors just exposed this |
ok, I will try and push something to address this |
If the binary is not existing twister won't report such case as error. This patch fixes this. fixes: zephyrproject-rtos#72807 Signed-off-by: Maciej Perkowski <Maciej.Perkowski@nordicsemi.no>
Deal with binaries not found. Also set default return code to something other than zero to catch issues and report correct status. Fixes zephyrproject-rtos#72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Handle all exceptions when running tests. Fixes zephyrproject-rtos#72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Abort execution in case of exceptions. Fixes zephyrproject-rtos#72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Abort execution in case of exceptions. Fixes zephyrproject-rtos#72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
When something goes wrong with execution, due to twister issues and bugs, do not continue with execution and abort the process and report and return an error code. Fixes zephyrproject-rtos#72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
When something goes wrong with execution, due to twister issues and bugs, do not continue with execution and abort the process and report and return an error code. Fixes zephyrproject-rtos#72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
When something goes wrong with execution, due to twister issues and bugs, do not continue with execution and abort the process and report and return an error code. Fixes #72807 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
There are a lot of python exceptions being thrown in twister CI runs, but the run doesn't get marked as failed:
Example: https://github.com/zephyrproject-rtos/zephyr/actions/runs/9094695276/job/24996411498#step:11:131
As far as I can tell, this kills the twister process and half the tests aren't even being run, yet no failure is reported in the GitHub action.
The text was updated successfully, but these errors were encountered: