Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable $enable_drafts is used before it is assigned in configure.ac #4612

Open
ellert opened this issue Oct 31, 2023 · 1 comment
Open

Comments

@ellert
Copy link

ellert commented Oct 31, 2023

[enable_ws=$enable_drafts])

In the line above, the variable $enable_drafts is used before it is assigned. The intended purpose of using the value of --enable-drafts as the defaut value for ----enable-ws is therefore not accomplished.

@ellert
Copy link
Author

ellert commented Oct 31, 2023

Since due to the above the default value for enable_ws is the empty string, the condition

if test "x$enable_ws" != "xno"; then

results in that ws will be enabled by default. To make this explicit (and so that ./configure --help shows the default that is actually used) this could be changed to:

AC_ARG_ENABLE([ws],
    [AS_HELP_STRING([--enable-ws], [Enable WebSocket transport [default=yes]])],
    [enable_ws=$enableval],
    [enable_ws=yes])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant