"configure --help" output doesn't match actual behaviour

[ellert]

What is the intended behaviour here?

• The documented behaviour from "configure --help", i.e. drafts enabled by default, or
• The implemented behaviour, i.e. drafts disabled by default (unless building from a git checkout).

libzmq/configure.ac

Lines 1029 to 1042 in f0c471a

	if test "x$cross_compiling" = "xyes"; then
	# Enable draft by default when cross-compiling
	defaultval=yes
	else
	# enable draft API by default if we're in a git repository
	# else disable it by default; then allow --enable-drafts=yes/no override
	AC_CHECK_FILE($srcdir/.git, [defaultval=yes], [defaultval=no])
	fi
	AC_ARG_ENABLE([drafts],
	AS_HELP_STRING([--enable-drafts],
	[Build and install draft classes and methods [default=yes]]),
	[enable_drafts=$enableval],
	[enable_drafts=$defaultval])

I would prefer to change the implemented behaviour to match the documented behaviour, i.e.

AC_ARG_ENABLE([drafts], 
    AS_HELP_STRING([--enable-drafts], 
        [Build and install draft classes and methods [default=yes]]), 
    [enable_drafts=$enableval], 
    [enable_drafts=yes]) 

(and remove the definition of the now unused defaultval).

But if this is not acceptible, change the documentation to match the implementation:

AC_ARG_ENABLE([drafts], 
    AS_HELP_STRING([--enable-drafts], 
        [Build and install draft classes and methods [default=$defaultval]]), 
    [enable_drafts=$enableval], 
    [enable_drafts=$defaultval]) 

As it is now, users reading the output of "configure --help" think they have drafts enabled when they actually have not.