Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8_COMPILE_CACHE_CACHE_DIR default doesn't match README #38

Open
lightmare opened this issue Jul 8, 2021 · 0 comments
Open

V8_COMPILE_CACHE_CACHE_DIR default doesn't match README #38

lightmare opened this issue Jul 8, 2021 · 0 comments

Comments

@lightmare
Copy link

README says it defaults to <os.tmpdir>/v8-compile-cache-<v8.version>
whereas the code defaults to <os.tmpdir>/v8-compile-cache-<UID>/<v8.version>

Aside from that, I think it'd make more sense for the variable to only specify the base dir, and for <v8.version> to always be appended,
i.e. given V8_COMPILE_CACHE_CACHE_DIR=/my/v8cache
files would go in /my/v8cache/<v8.version>/*.BLOB etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant