Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes around du path breaks wildcard expansion #144

Open
mickaelperrin opened this issue Sep 23, 2016 · 1 comment
Open

Quotes around du path breaks wildcard expansion #144

mickaelperrin opened this issue Sep 23, 2016 · 1 comment
Labels

Comments

@mickaelperrin
Copy link

Hi,

Thanks for this really useful project !

I get into troubles while trying to use the INCLIST parameter with wildcards.

At line 587, the quotes around the path break the du command to expand wildcards.

However, removing the quotes may introduce problems for paths containing spaces...

So, it looks like supporting wildcard, needs a little more work than just removing quotes.

@zertrin
Copy link
Owner

zertrin commented Sep 29, 2016

Ah... Quotes, spaces and wildcard, such a nice mix ^^

Thanks for reporting, as I'm not using wildcards a lot I didn't notice it. You're right, the big shellcheck cleaning may have introduced/revealed new bugs recently.

I'm wondering if the solution to this issue may come from altering IFS temporarily again and removing the quotes...

I don't have much time currently to look into it, but who knows, maybe I'll tackle this in some moment of boredom. In the meantime, since du isn't critical to the backup task, I'll lean toward keeping the quotes until a working solution is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants