Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prepare): add support for bumping package build number #155

Merged
merged 10 commits into from
Jan 4, 2024

Conversation

async3619
Copy link
Contributor

@async3619 async3619 commented Jan 2, 2024

Summary

This PR resolves #152.

this PR will add increasing version code support for every version bump. This will change version code like these:

Without version code

- version: 1.0.0
+ version: 1.0.1+1

With version code

- version: 1.0.0+1
+ version: 1.0.1+2

version code will be increased by 1 on every bumps.

Config

I've added useVersionCode field on configuration because I thought I should add configuration field to set whether use version code or not. (since some of users wouldn't want to use version codes on their own pub packages)

Option Description Default
useVersionCode Whether to write version code for every newly bumped version in pubspec.yaml (Learn more) false

README.md Outdated Show resolved Hide resolved
src/prepare.ts Outdated Show resolved Hide resolved
src/prepare.ts Outdated Show resolved Hide resolved
src/prepare.ts Outdated Show resolved Hide resolved
@zeshuaro
Copy link
Owner

zeshuaro commented Jan 3, 2024

Can you also merge with latest main? I pushed a fix to hopefully address one of the failing steps on your PR.

README.md Outdated Show resolved Hide resolved
@zeshuaro zeshuaro changed the title feat(version-code): add support for bumping package version code feat(prepare): add support for bumping package build number Jan 4, 2024
Co-authored-by: Joshua Tang <joshuaystang@gmail.com>
@zeshuaro zeshuaro merged commit 80bf1f5 into zeshuaro:main Jan 4, 2024
7 checks passed
zeshuaro pushed a commit that referenced this pull request Jan 7, 2024
## [0.7.0](v0.6.2...v0.7.0) (2024-01-07)

### Features

* **prepare:** add support for bumping package build number ([#155](#155)) ([80bf1f5](80bf1f5))

### Documentation

* **readme:** link sample pull request for setup ([#153](#153)) ([9333887](9333887))

### Styles

* add `eslint-config-prettier` and format with prettier ([#147](#147)) ([06c5508](06c5508))

### Miscellaneous Chores

* add prettier config ([#164](#164)) ([6329e20](6329e20))
* **deps:** lock file maintenance ([#132](#132)) ([f0979a7](f0979a7))
* **deps:** lock file maintenance ([#140](#140)) ([c053e42](c053e42))
* **deps:** lock file maintenance ([#150](#150)) ([2ef7ce7](2ef7ce7))
* **deps:** update dependency eslint to v8.56.0 ([#142](#142)) ([e757757](e757757))
* **deps:** update dependency eslint-plugin-import to v2.29.1 ([#141](#141)) ([c897c18](c897c18))
* **deps:** update dependency eslint-plugin-n to v16.4.0 ([#138](#138)) ([79069a7](79069a7))
* **deps:** update dependency eslint-plugin-n to v16.5.0 ([#145](#145)) ([1984573](1984573))
* **deps:** update dependency eslint-plugin-n to v16.6.0 ([#151](#151)) ([54a2fcc](54a2fcc))
* **deps:** update dependency eslint-plugin-n to v16.6.1 ([#167](#167)) ([f76eb30](f76eb30))
* **deps:** update dependency prettier to v3.1.1 ([#133](#133)) ([bafedbe](bafedbe))
* **deps:** update dependency semantic-release to v22.0.12 ([#137](#137)) ([e953995](e953995))
* **deps:** update typescript-eslint monorepo to v6.14.0 ([#139](#139)) ([ddacb4f](ddacb4f))
* **deps:** update typescript-eslint monorepo to v6.15.0 ([#143](#143)) ([815bef4](815bef4))
* **deps:** update typescript-eslint monorepo to v6.16.0 ([#149](#149)) ([8f5079f](8f5079f))
* **deps:** update typescript-eslint monorepo to v6.17.0 ([#168](#168)) ([22e3e9a](22e3e9a))
* **deps:** update vitest monorepo to v1.0.2 ([#131](#131)) ([fdc6e31](fdc6e31))
* **deps:** update vitest monorepo to v1.0.4 ([#134](#134)) ([f7c6c73](f7c6c73))
* **deps:** update vitest monorepo to v1.1.0 ([#144](#144)) ([30d6560](30d6560))
* **deps:** update vitest monorepo to v1.1.1 ([#158](#158)) ([8731bd2](8731bd2))
* remove sonarcloud references ([#173](#173)) ([f6ba5cb](f6ba5cb))
* update vscode configs ([#146](#146)) ([15f0512](15f0512))

### Tests

* **prepare:** fix failing tests ([#163](#163)) ([cf46430](cf46430))

### Continuous Integration

* add codecov config ([#172](#172)) ([0bf32ef](0bf32ef))
* **deps:** update sonarsource/sonarcloud-github-action action to v2.1.1 ([#135](#135)) ([cbb8750](cbb8750))
* **deps:** update zeshuaro/github-actions-workflows digest to 04a2125 ([#166](#166)) ([00fe905](00fe905))
* **deps:** update zeshuaro/github-actions-workflows digest to 29c0760 ([#154](#154)) ([62071dd](62071dd))
* **deps:** update zeshuaro/github-actions-workflows digest to 6f3f4e9 ([#148](#148)) ([89b73cf](89b73cf))
* **deps:** update zeshuaro/github-actions-workflows digest to 8050038 ([#156](#156)) ([120385e](120385e))
* **deps:** update zeshuaro/github-actions-workflows digest to b8a4973 ([#170](#170)) ([8ca9117](8ca9117))
* **deps:** update zeshuaro/github-actions-workflows digest to f09aca3 ([#160](#160)) ([fbc75b5](fbc75b5))
* **deps:** update zeshuaro/github-actions-workflows digest to fe18491 ([#136](#136)) ([d5ebca8](d5ebca8))
* **github-actions:** fix pull request args to sonarcloud ([#162](#162)) ([1ec98fe](1ec98fe))
* **github-actions:** fix to use `pull_request` trigger ([#165](#165)) ([395db4b](395db4b))
* **github-actions:** specify more pull request args to sonarcloud ([#161](#161)) ([25cc8ca](25cc8ca))
* **github-actions:** specify pull request to sonarcloud ([#159](#159)) ([332ef33](332ef33))
* **github-actions:** update to use `pull_request_target` trigger ([#157](#157)) ([705edaf](705edaf))
* migrate to codecov for test coverage ([#171](#171)) ([92b476e](92b476e))
* separate `pull_request` and `pull_request_target` actions ([#169](#169)) ([d96e38b](d96e38b))
@zeshuaro
Copy link
Owner

zeshuaro commented Jan 7, 2024

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does this plugin take care of version code of pubspec.version?
2 participants