Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF and EPUB formats require URL encoded URLs #238

Open
Situphen opened this issue Jul 5, 2018 · 2 comments
Open

PDF and EPUB formats require URL encoded URLs #238

Situphen opened this issue Jul 5, 2018 · 2 comments
Labels
blocked/wontfix Not intended to be fixed status/verified This has been checked by a maintainer type/question This does not need any changes

Comments

@Situphen
Copy link
Member

Situphen commented Jul 5, 2018

See zestedesavoir/zds-site#4962 (comment)

Works fine for the HTML, PDF and EPUB :

![Link](https://situphen.eu/static/image%C3%A8%C3%A8%C3%A8%20nomm$%20biza%C3%80%C3%80%C3%80%C3%80%C3%80rr%E2%82%AC%E2%82%AC%E2%82%AC%E2%82%AC.png)

Works fine for the HTML but doesn't appear for the EPUB and makes the PDF to be corrupted :

![Link](https://situphen.eu/static/imageèèè nomm$ bizaÀÀÀÀÀrr€€€€.png)
@vhf
Copy link
Contributor

vhf commented Jul 22, 2018

I'm not sure we can fix this.

  • Encoding all image URIs would break URIs already URI encoded.
  • Does the EPUB format really support remote images such as ![Link](https://situphen.eu/static…)?
  • Same question for PDFs.

@vhf vhf added the type/question This does not need any changes label Jul 22, 2018
@vhf vhf changed the title zmd accepts only URL already encoded for PDF and EPUB PDF and EPUB formats require URL encoded URLs Nov 29, 2018
@LikaKavkasidze
Copy link
Member

Is this still open question? May I close it? @Situphen

@LikaKavkasidze LikaKavkasidze added blocked/wontfix Not intended to be fixed status/verified This has been checked by a maintainer type/request This is great to have and removed type/request This is great to have labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/wontfix Not intended to be fixed status/verified This has been checked by a maintainer type/question This does not need any changes
Projects
None yet
Development

No branches or pull requests

3 participants