Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore images for the signature (message footer) #313

Open
A-312 opened this issue Feb 13, 2019 · 2 comments
Open

Ignore images for the signature (message footer) #313

A-312 opened this issue Feb 13, 2019 · 2 comments
Labels
blocked/upstream Awaiting for upstream changes semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/request This is great to have

Comments

@A-312
Copy link
Contributor

A-312 commented Feb 13, 2019 •
edited

Allow to disable image for the inline parser with an option.

zestedesavoir/zds-site/issues/5086
@artragis
Copy link
Member

In fact, what we want is to be able to add a custom element to the ignored ones when we request zmarkdown endpoints.

@A-312 can you edit the issue to write a well formatted ticket?

@A-312 A-312 changed the title Forbidden images in Signature (message footer) Ignore images for the signature (message footer) Feb 13, 2019
@LikaKavkasidze LikaKavkasidze added misc/easy Good first issue semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/request This is great to have labels Feb 3, 2020
@LikaKavkasidze LikaKavkasidze mentioned this issue Feb 6, 2020
Merged
@LikaKavkasidze
Copy link
Member

Added an option for this today, but I'm not sure it will solve your problem, unfortunately; images are tokenized at the same time as links/url in remark, which means we cannot disable only one at a time: if we loose images, we loose links...

@LikaKavkasidze LikaKavkasidze added blocked/upstream Awaiting for upstream changes and removed misc/easy Good first issue labels Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/upstream Awaiting for upstream changes semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/request This is great to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@artragis @LikaKavkasidze @A-312