Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of base64 image #404

Open
Heziode opened this issue Jun 11, 2020 · 7 comments
Open

Add support of base64 image #404

Heziode opened this issue Jun 11, 2020 · 7 comments
Labels
misc/help wanted This issue needs help semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/request This is great to have

Comments

@Heziode
Copy link
Contributor

Heziode commented Jun 11, 2020

Support of base64 image could be useful.

For HTML part (Rehype) it shouldn’t be a problem.
For LaTeX, this will require to convert the image into a binary file and use the path of the image into the generated LaTeX file (IHMO).
For Epub, I don’t know…

@artragis
Copy link
Member

For Epub, I don’t know…

this is HTML. So you can use the rehype behaviour.

@LikaKavkasidze
Copy link
Member

For LaTeX, I think we can add this to remark-image-download.

@LikaKavkasidze LikaKavkasidze added misc/help wanted This issue needs help semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/request This is great to have labels Jun 11, 2020
@LikaKavkasidze
Copy link
Member

Hello 👋

I am seeing this issue again after a while, and apart from how we could implement it, I am wondering if it is really needed. Do you have an use case for this?

@Heziode
Copy link
Contributor Author

Heziode commented Jul 8, 2022

I don't remember clearly, but it is probably to working in offline mode (without internet).
Or maybe with image generated by software like Draw.io where we do not want to point to an URL / file.

@LikaKavkasidze
Copy link
Member

Working in offline mode isn't possible on the ZdS editor by now, because request are sent to the ZMarkdown server to get the rendered content.
For generated images, I guess it could be useful, but I do not think it is really worth it, uploading an image takes very little time for the user. It would require a lot of efforts from us, for something that will be used by very few people, if any...

@Heziode
Copy link
Contributor Author

Heziode commented Aug 14, 2022

@StaloneLab even if ZMarkdown is originally designed for ZdS, keep in mind that it can also be used by people in other manner, different editors, etc. (the joy of open-source)

@LikaKavkasidze
Copy link
Member

That is indeed true. However, even if it can be used externally, it has not been made for this usage (although we do welcome and help people trying to install it), and new functionalities are implemented depending on the needs of ZdS.
Note that this is not true for the plugins individually, which are made to be (and are) used externally. People requiring additional plugins may therefore develop their own ones and use the plugins we provide as part of their rendering engine.

Occasionally, we can accept PR for new functionalities if we feel these are nice to have on ZdS, and are ready to maintain them, but never have we developed plugins for external uses.
So, back to the question, I'm doubting here both: 1. that it will be useful for ZdS (and therefore that we want to develop it) and 2. that it should go into ZMarkdown at all, knowing that it is not needed at all by us, and likely complicated to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/help wanted This issue needs help semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/request This is great to have
Projects
None yet
Development

No branches or pull requests

3 participants