Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remark-captions: remove one image when Figure follows two images #479

Open
artragis opened this issue Dec 2, 2022 · 1 comment
Open
Labels
semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/bug This is a problem

Comments

@artragis
Copy link
Member

artragis commented Dec 2, 2022

input

![Configuration du projet de test avec IntelliJ, on donne le nom "tuto" au projet puis on sélectionne maven en tant que système de build](/media/galleries/502/3b362168-4ea0-4698-b92b-319c902b8fe1.png)
![Résultat de la configuration : un arbre est créé avec le dossier .idea, le dossier src et le fichier pom.xml. Dans le dossier src on a un dossier main et un dossier test, ces deux derniers ont un dossier java](/media/galleries/502/b09e3d72-f0e6-4ba4-b4b4-d9a11a8a9981.png)
Figure: Configuration de notre projet et hiérarchie qui en résulte

optained

Only one image is displayed
image

Expected

Two possibilities :

  • the two images are displayed in the same figure mark
  • two images = two figure marks
@LikaKavkasidze LikaKavkasidze added type/bug This is a problem semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer labels Dec 3, 2022
@LikaKavkasidze
Copy link
Member

Thanks for reporting, this looks like a tricky problem. To make it clear, because I thought the behavior was intended at first: the problem does not happen when the Figure: caption is absent, the two images appear correctly, as expected from the GFM specification (images are inlines). The result from the caption should at least not break anything. In my opinion, we should get two images under the same figure mark (hence treating the caption as a container block, with two inlines in it).

However this problem is easily mitigated by adding a line break between the two images, which would result in the two images treated as two different figures, one of the two having a default caption (which can also be changed using Figure:). This is also why I think the behavior should not be this one if the two images are not separated by a line break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor This is a backward-compatible change status/verified This has been checked by a maintainer type/bug This is a problem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants