Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple images in figure #485

Closed
wants to merge 2 commits into from
Closed

Conversation

artragis
Copy link
Member

This PR intents to enable multiple images in figures

fix #479

For now it only fails with rebber as plugin relies on the assumption there is only one image

@LikaKavkasidze
Copy link
Member

From what I see, this PR is not ready to be merged. Am I right? If so, I will release a new version with your bugfixes for the escaping code, and this PR will be merged when ready. I will anyway make a review of the PR soon, to see what it does in more details.

@artragis
Copy link
Member Author

This PR is not ready mainly due to the latex part. Il will ask some question to latex people before finishing it.

It also seems I, as usual, face a linter hell.

Copy link
Member

@LikaKavkasidze LikaKavkasidze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me for the HTML part, I haven't found the linter problems you were talking about. There were some tests failing that shouldn't have been, but running the tests again fixed the problem, the only one still failing is the LaTeX part of the test you added.

@LikaKavkasidze
Copy link
Member

What is the current state of this PR? Should I close it? It has been almost a year without activity.

@LikaKavkasidze
Copy link
Member

No news and no answer, closing for now, feel free to reopen if needed.

@artragis
Copy link
Member Author

sorry for not responding, I do not really have time nor motivation. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remark-captions: remove one image when Figure follows two images
2 participants