From 0fbc9e03f74ec116d021dc6c1f5f1e7c8f4f8ff6 Mon Sep 17 00:00:00 2001 From: Evan You Date: Mon, 14 Nov 2022 16:57:44 +0800 Subject: [PATCH] chore: fix assertNumber for undefined value --- packages/runtime-core/src/warning.ts | 4 +++- packages/runtime-dom/src/components/Transition.ts | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/runtime-core/src/warning.ts b/packages/runtime-core/src/warning.ts index b314985b771..8e93d9efe59 100644 --- a/packages/runtime-core/src/warning.ts +++ b/packages/runtime-core/src/warning.ts @@ -168,7 +168,9 @@ function formatProp(key: string, value: unknown, raw?: boolean): any { */ export function assertNumber(val: unknown, type: string) { if (!__DEV__) return - if (typeof val !== 'number') { + if (val === undefined) { + return + } else if (typeof val !== 'number') { warn(`${type} is not a valid number - ` + `got ${JSON.stringify(val)}.`) } else if (isNaN(val)) { warn(`${type} is NaN - ` + 'the duration expression might be incorrect.') diff --git a/packages/runtime-dom/src/components/Transition.ts b/packages/runtime-dom/src/components/Transition.ts index 205bea9668f..a331c53c235 100644 --- a/packages/runtime-dom/src/components/Transition.ts +++ b/packages/runtime-dom/src/components/Transition.ts @@ -283,7 +283,9 @@ function normalizeDuration( function NumberOf(val: unknown): number { const res = toNumber(val) - if (__DEV__) assertNumber(res, ' explicit duration') + if (__DEV__) { + assertNumber(res, ' explicit duration') + } return res }