Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemaVersion of DAC PKI Revocation Distribution Point schema did not get bumped after #557 #566

Closed
tcarmelveilleux opened this issue Apr 23, 2024 · 1 comment
Closed

SchemaVersion of DAC PKI Revocation Distribution Point schema did not get bumped after #557 #566

tcarmelveilleux opened this issue Apr 23, 2024 · 1 comment
Assignees
@Abdulbois
Projects
DCL 1.4

Comments

@tcarmelveilleux
Copy link

PR #557 added a field to the CRL distribution point schema (CRLSignerDelegator) but the SchemaVersion was not bumped. https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/9126 will bump the version, but it has to be bumped also in the DCL implementation.
@akarabashov akarabashov added this to To do in DCL 1.4 May 22, 2024
Abdulbois added a commit that referenced this issue May 22, 2024
@Abdulbois
improvements #566 #570
6a3b669 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois added a commit that referenced this issue May 22, 2024
@Abdulbois
improvements #566 #570
b8ea77b 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois added a commit that referenced this issue May 22, 2024
@Abdulbois
improvements #566 #570
cef747a 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois added a commit that referenced this issue May 23, 2024
@Abdulbois
improvements #566 #570
22427d1 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois added a commit that referenced this issue May 23, 2024
@Abdulbois
improvements #566 #570
034c07c 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
@akarabashov akarabashov moved this from To do to In Review in DCL 1.4 May 24, 2024
akarabashov added a commit that referenced this issue May 24, 2024
@akarabashov
Merge pull request #572 from zigbee-alliance/improvements
ccac781 
improvements #566 #570
Abdulbois added a commit that referenced this issue May 27, 2024
@Abdulbois
improvements #566 #570
fd504a2 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
@akarabashov
Copy link
Collaborator

PR: #572

The default version of SchemaVersion for PkiRevocationDistributionPoint is set to 1

@akarabashov akarabashov moved this from In Review to Done in DCL 1.4 May 27, 2024
Abdulbois added a commit that referenced this issue May 31, 2024
@Abdulbois
improvements #566 #570
104908e 
- Bump schemaVersion of PKI Distribution Point model
- Add base64 format validation for OTAChecksum of Model Version model

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abdulbois Abdulbois

Labels
None yet
Projects
DCL 1.4
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcarmelveilleux @Abdulbois @akarabashov