-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
astgen: fix result info for catch switch_block_err_union #19899
Conversation
Looks like the new tests as hitting a TODO in the wasm backend for lowering error union payload pointers. I'd probably need some guidance on how to implement that unless it's acceptable the skip the tests on wasm. |
It is. |
Head branch was pushed to by a user without write access
ad3a846
to
33c6937
Compare
Okay - I've disabled the address-of tests with the wasm backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test: disable failing err union switch tests on wasm
This commit message doesn't reflect what is happening in that commit. You're making a lot of changes to behavior tests, what's going on there?
Each of the commented out function calls in test "switch on error union if else capture" would fail on wasm (I didn't check, but I'm pretty sure it will be the same reason as for the address-of tests). The commit is just cut-pasting them into the test "ptr tests" (which probably needs a better name) so they can be disabled on wasm, and unfortunately the diff algorithm doesn't seem to handle it well. Would you prefer I simply disable the whole original "switch on error union if else capture" test? |
Yeah, don't restructure the tests to favor slightly better testing of a backend which is unused in practice. Just disable the whole test for the WASM backend, and it can be re-enabled when the backend is improved. |
994d098
to
b264cc4
Compare
Okay - I've just disabled all the tests rather than splitting apart those that did or didn't pass on wasm. |
Fixes #19881.
Todo