Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto reference screenshot generation foils testing in retry scenario #105

Open
alisman opened this issue Jan 14, 2022 · 0 comments
Open

Comments

@alisman
Copy link

alisman commented Jan 14, 2022

Retries are an essential part of e2e in order to deal with flakey tests.

When a screenshot is missing, the framework creates a new one and saves it. This causes a retry to PASS. I would argue that the framework should never automatically create a reference screenshot. Or at least there should be a flag to prevent if from doing so. The reference screenshots should be copied manually from screens directory by developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant