Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots slowing down test #72

Open
yebrahim opened this issue Mar 29, 2018 · 1 comment
Open

Screenshots slowing down test #72

yebrahim opened this issue Mar 29, 2018 · 1 comment

Comments

@yebrahim
Copy link

Is there a way of taking the screenshot, saving it to disk, and diffing it against the reference in an async mode? I can see the browser have to wait for a second or so for each checkDocument call, slowing the test suite quite a bit. It would be great if the browser can rush through the tests and queue up the image saving/diffing separately.

@zinserjan
Copy link
Owner

Sorry for the late response.

Since v0.9.0 the image comparison is async for each screenshot taken in a checkDocument call. But it blocks the command of course until all images are compared, otherwise we cannot provide the result report.

But I'm not sure if this is the case for LocalCompare cause it uses node-resemble-js. Feel free to test it. If it isn't async maybe we can use some kind of worker for resemblejs like worker-farm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants