Resolve #8696 #8845
Merged
Resolve #8696 #8845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay. |
hearnadam
reviewed
May 11, 2024
|
@BijenderKumar1 Could you add some tests, please? |
…HS variable updates in orElse Test Suite
|
@guizmaii @hearnadam I have added a new test to make sure that the variable changes on the LHS of an orElse construct, trigger a retry. I have also made sure that all the existing tests pass. Thanks! |
jdegoes
reviewed
May 12, 2024
|
@jdegoes @hearnadam Just a gentle reminder! Thanks! |
|
@jdegoes @hearnadam Just a gentle reminder to review this. Sorry to bother you. |
jdegoes
approved these changes
May 21, 2024
|
@jdegoes Thanks for approving the changes. Just a gentle reminder to please merge the PR as well, if possible? Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #8696, which happens as the journal reset does not happen accurately, and instead empties the journal. I resolved this issue with the
prepareJournalResetfunction.I tested using the same code provided in the issue #8696, and it no longer hangs.
Thanks!
/claim #8696