Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept text/plain data #119

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

rchl
Copy link
Contributor

@rchl rchl commented Aug 2, 2022

Sentry is making requests with text/plain content-type which fails to parse without text/plain handler.

Sentry documentation states:

Envelope requests may contain all headers as regular store requests. The only accepted content-type is application/x-sentry-envelope, which is implied if it is missing. To minimize the necessity for CORS preflights it's acceptable to send text/plain, multipart/form-data and application/x-www-form-urlencoded as well. In either of those cases the behavior however is the same as using application/x-sentry-envelope.
https://develop.sentry.dev/sdk/envelopes/

It's a bit confused about the use of "the only accepted" but otherwise should be clear that text/plain is also allowed.

Resolves #104

@zivl zivl mentioned this pull request Aug 3, 2022
@zivl zivl merged commit b491bcb into zivl:master Aug 3, 2022
@rchl rchl deleted the fix/plain-text-request branch August 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Body not parsed
2 participants