Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Return Typed sentryTransport function #142

Open
zivl opened this issue Oct 23, 2022 · 9 comments
Open

[Feature Request]: Return Typed sentryTransport function #142

zivl opened this issue Oct 23, 2022 · 9 comments
Labels
enhancement good first issue help wanted

Comments

@zivl
Copy link
Owner

zivl commented Oct 23, 2022

Typed sentryTransport function

After the code base move to TypeScript, we got rid of the manual *.d.ts files which caused issues with the implicit returned type of sentryTransport function.

The main cause that we cannot use the straitforward retuned type is because we want to support multiple Sentry versions, and that results in multiple conflicted interfaces (some of them are breaking changes).

We need to come up with something we have done on our manual definition file back then:

  type V6TransportClass = {
    new (): Transport
  }

  type V7TransportFunction = () => Transport

But the above is also not straitforward for the TS compiler to digest (for some reason).
For me personally, I'm a TypeScript newbe so I'm looking for the right solution here... any kind of help is welcomed!
@zivl zivl mentioned this issue Oct 23, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

Stale issue message

@liamjones liamjones mentioned this issue Jan 1, 2023
Closed
@github-actions github-actions bot closed this as completed Jan 8, 2023
@zivl zivl reopened this Jan 8, 2023
@github-actions
Copy link
Contributor

Stale issue message

@zivl zivl reopened this Mar 19, 2023
@github-actions
Copy link
Contributor

Stale issue message

@github-actions
Copy link
Contributor

Stale issue message

@github-actions
Copy link
Contributor

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

@github-actions GitHub Actions
Copy link
Contributor

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zivl