Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sentry v8 #200

Open
Slessi opened this issue May 17, 2024 · 2 comments
Open

Support Sentry v8 #200

Slessi opened this issue May 17, 2024 · 2 comments

Comments

@Slessi
Copy link

Slessi commented May 17, 2024

Is your feature request related to a problem? Please describe.
I am trying to update my project to use sentry v8, but was blocked by apollo-link-sentry. I tried to update that package in DiederikvandenB/apollo-link-sentry#467 but the tests are failing, and it may be due to this package.

Tests pass individually, but fail if ran together, so I am not sure the testkit.reset() is working in v8 anymore.

Describe the solution you'd like
sentry-testkit to work with sentry v8

Describe alternatives you've considered
Quitting JS development and starting a farm

Additional context

@Slessi
Copy link
Author

Slessi commented May 20, 2024

Seems like there was actually just a problem on my part in DiederikvandenB/apollo-link-sentry#467 (comment), so I'm not blocked by this. Worth keeping the issue open though as probably still desirable to update.

@zivl
Copy link
Owner

zivl commented May 22, 2024

hey @Slessi
yeah you are right... we need to add support for the new major version of Sentry@8 packages.
I actually believe we are also compatible with Sentry@8 but first let's read the breaking changes carefully and add some tests.

I think the go to from here is to be able to install different sentry versions in the github action CI workflow and by that to verify we are always on the good side of things :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants