Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[cold] to some of the constructor functions #375

Open
Boshen opened this issue May 9, 2024 · 3 comments · May be fixed by #378
Open

Add #[cold] to some of the constructor functions #375

Boshen opened this issue May 9, 2024 · 3 comments · May be fixed by #378
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Boshen
Copy link
Contributor

Boshen commented May 9, 2024

While going over the commit history of anyhow, I see that dtolnay/anyhow@fa9bcc0 may benefit us as well, should we copy them over?

background issue: dtolnay/anyhow#165
@zkat
Copy link
Owner

zkat commented May 9, 2024

I'd definitely take a PR doing this!

@zkat zkat added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 9, 2024
@re-taro
Copy link

re-taro commented May 11, 2024

@zkat Hello! I would like to address this issue!

@Boshen
Copy link
Contributor Author

Boshen commented May 11, 2024

@zkat Hello! I would like to address this issue!

Feel free to submit a PR.

@re-taro re-taro linked a pull request May 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: mark error constructors cold re-taro/miette
3 participants
@zkat @Boshen @re-taro