Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing babel/polyfill crashes ie11 #485

Closed
babel-bot opened this issue Feb 5, 2019 · 10 comments
Closed

Importing babel/polyfill crashes ie11 #485

babel-bot opened this issue Feb 5, 2019 · 10 comments

Comments

@babel-bot
Copy link

Original issue submitted by @Ashot-KR in babel/babel#9456

Importing @babel/polyfill crashes IE.

crash

Build environment

  • Node/npm version: node v10.15.0, npm 6.7.0
  • MacOS 10.13.6
@zloirock
Copy link
Owner

zloirock commented Feb 5, 2019

@Ashot-KR please, add a reproducible example.

@Ashot-KR
Copy link

Ashot-KR commented Feb 5, 2019

import 'core-js' crashes ie.
IE 11.0.9600.16384 on Win7 crashes
but IE 11.0.10240.17443 on Win10 is OK

Steps to reproduce:
Generate project with create-react-app

npm create-react-app test-project

add import 'core-js' on the top of src/index.js file

@Ashot-KR
Copy link

Ashot-KR commented Feb 5, 2019

@zloirock https://jsfiddle.net/bpzv9o7x/ fiddle with core-js from cdn

@zloirock
Copy link
Owner

zloirock commented Feb 5, 2019

It works fine on IE 11.0.9600.18665 on Win 7, I have no ideas where I can test it on 11.0.9600.16384.

@nicolo-ribaudo
Copy link
Contributor

@Ashot-KR Did is starter throwing recently? If yes, could you try to understand in which version?

@Ashot-KR
Copy link

Ashot-KR commented Feb 5, 2019

looks like reason somewhere in core-js/modules/es6.weak-map.

It works fine on IE 11.0.9600.18665 on Win 7, I have no ideas where I can test it on 11.0.9600.16384.

I'm the lucky one 😄 Could it be an IE bug? 🤔

@zloirock
Copy link
Owner

zloirock commented Feb 5, 2019

It's definitely IE bug.

If it's exactly in core-js/modules/es6.weak-map, most likely it's the detection of support frozen WeakMap keys.

Could you replace this condition to true and run it again?

@zloirock zloirock added the ie label Feb 5, 2019
@Ashot-KR
Copy link

Ashot-KR commented Feb 5, 2019

Could you replace this condition to true and run it again?

@zloirock it stop crashing with true condition

zloirock added a commit that referenced this issue Feb 6, 2019
zloirock added a commit that referenced this issue Feb 6, 2019
@zloirock zloirock closed this as completed Feb 6, 2019
@zloirock
Copy link
Owner

zloirock commented Feb 6, 2019

@Ashot-KR could you try it with this bundle?

@Ashot-KR
Copy link

Ashot-KR commented Feb 6, 2019

@zloirock looks like it's ok
https://jsfiddle.net/bpzv9o7x/1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants