Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol exception in IE11 again @ 3.1.0 #550

Closed
scrollbar-ww opened this issue May 20, 2019 · 7 comments
Closed

Symbol exception in IE11 again @ 3.1.0 #550

scrollbar-ww opened this issue May 20, 2019 · 7 comments

Comments

@scrollbar-ww
Copy link

i use rollup + babel@7 + core-js for bundling my web app,
after update core-js from 3.0.1 to 3.1.0, i got a new symbol exception .

@ core-js/packages/core-js/modules/es.symbol.js :

$export({ target: 'Object', stat: true, forced: fails(function () { getOwnPropertySymbolsModule.f(1); }) }, {
  getOwnPropertySymbols: function getOwnPropertySymbols(it) {
    return getOwnPropertySymbolsModule.f(toObject(it));
  }
});

"getOwnPropertySymbolsModule" equals undefined, which import from:
var getOwnPropertySymbolsModule = require('../internals/object-get-own-property-symbols');

there was a similar exception with 3.0.0, but fixed in 3.0.1.
https://github.com/zloirock/core-js/issues/513

@zloirock
Copy link
Owner

How it could be equals undefined? object-get-own-property-symbols exports an object.

Please, provide more info or a reproducible example.

@scrollbar-ww
Copy link
Author

sorry, it's "getOwnPropertySymbolsModule.f" equals undefined, in IE 11

@zloirock
Copy link
Owner

I have no ideas in which case it's possible. Seems a new kind of strange rollup optimizations. In which engine you have this problem? Maybe you could create a reproducible example?

@scrollbar-ww
Copy link
Author

sorry again, it caused by another package, that try to implement window.Symbol, but not completely.
it makes "NATIVE_SYMBOL" equals true, without "getOwnPropertySymbols" method.
but the strange thing is, it's ok with core-js 3.0.1

@zloirock
Copy link
Owner

I'll add an additional check for NATIVE_SYMBOL, thanks.

@zloirock
Copy link
Owner

Added.

@PikachuEXE
Copy link

In case people don't know
The fix is committed in 08d2f56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants