[core-js-compat] Filter available modules without using an intermediate set #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Jul 4, 2019
packages/core-js-compat/package.json
Outdated
| "semver": "^6.1.3" | ||
| }, | ||
| "devDependencies": { | ||
| "core-js-pure": "3.1.4", |
There was a problem hiding this comment.
This is still used by packages/core-js-compat/src/build-entries.js (which isn't included in the published package, so it can be a dev dependency).
There was a problem hiding this comment.
Since it's a similar case like in index, it would be better also replace it.
zloirock
reviewed
Jul 4, 2019
| @@ -19,7 +18,7 @@ function getModulesForEntryPoint(entry) { | |||
| const relative = resolve(dir, dependency); | |||
| result.push(...getModulesForEntryPoint(relative)); | |||
| } | |||
| return [...intersection(new Set(result), order)]; | |||
| return result.sort((a, b) => order.indexOf(a) > order.indexOf(b) ? 1 : -1); | |||
There was a problem hiding this comment.
Oh I tought that you meant to remove intersection like this. Would it be ok to leave it there as it was before?
There was a problem hiding this comment.
Something like
const resultSet = new Set(result);
return order.filter(it => resultSet.has(it));could be better.
There was a problem hiding this comment.
O(n) vs O(n^2*log n) if I understood correctly.
There was a problem hiding this comment.
Yeah good idea.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: babel/babel#10158 (comment)