- harmonize the viewlet and browserpage allowed_interface declarations #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look into this PR on Alpine City Sprint starting in 14 days. |
mgedmin
reviewed
Jan 27, 2020
There was a problem hiding this comment.
I don't know if this is right. What does zope.browserpage do? (It does list(interface), but I don't remember if that includes parent interfaces or not).
EDIT: I checked, and list(interface) returns all the names, including those inherited from parent interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #755
I never used the viewlet declaration, so I can't say much about what the patch really does. If someone with enough knowledge could take a look and comment (or merge) that would be great. I'll do the backport to 4.x at that point.