Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin flake8 and plugins #826

Open
icemac opened this issue May 15, 2020 · 1 comment
Open

Pin flake8 and plugins #826

icemac opened this issue May 15, 2020 · 1 comment
Labels
enhancement
Projects
Zope 4 bugfix Zope 5

Comments

@icemac
Copy link
Member

icemac commented May 15, 2020

#823 arose because flake8 and its plug-ins are not pinned in constraints.txt.
To prevent such surprises in the future I suggest to pin every package used in tox.ini in versions.cfg so it gets propagated to constraints.txt.
This makes requirements.txt more useless because it then will install too many things not needed to run Zope. Maybe we should drop requirements.txt completely.
@icemac icemac mentioned this issue May 15, 2020
Closed
@dataflake
Copy link
Member

Don't forget that this may be the first time this ever happened (unpinned requirements from tox.ini breeaking things). Maybe this is for another day when we see it again.

@jugmac00 jugmac00 mentioned this issue Sep 24, 2020
Closed
@icemac icemac added this to To do in Zope 5 via automation Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Zope 4 bugfix
  
Awaiting triage
Zope 5
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run flake8 via pre-commit zopefoundation/Zope
2 participants
@icemac @dataflake