Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props removed with clean and inline options set to true #45

Open
mattarau opened this issue Aug 20, 2019 · 0 comments
Open

Props removed with clean and inline options set to true #45

mattarau opened this issue Aug 20, 2019 · 0 comments

Comments

@mattarau
Copy link

This is almost the same as #16, but in this case it happens when both clean and inline options are set to true.

With this config:

  _habitat.render({
    inline: false,
    clientSpecified: true,
    clean: true
  });

This will work:

  <div class="container">
    <div>LOADING...</div>
    <script type="application/json">
      {
        "token": "kdj4JLH$Kjhdljkio8erO",
      }
    </script>
  </div>

  <script async src="/bundle.js" data-mount-in=".container"></script>

But if you config it like this:

  _habitat.render({
    inline: true,
    clean: true
  });

The following implementation will remove the props.

  <div class="container">
    <div>LOADING...</div>
    <script type="application/json">
      {
        "token": "kdj4JLH$Kjhdljkio8erO",
      }
    </script>
    <script async src="/bundle.js"></script>
  </div>
@mattarau mattarau changed the title Props removed with clean option when inline Props removed with clean and inline options set to true Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant