Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses should not be retried #1086

Open
cdjackson opened this issue Jul 19, 2020 · 3 comments
Open

Responses should not be retried #1086

cdjackson opened this issue Jul 19, 2020 · 3 comments
Labels
bug pinned Will not be closed, even if stale

Comments

@cdjackson
Copy link
Member

I noticed that a response to a request from a remote device was being retried 10 or 20 seconds after failing by the TransactionManager. This makes me wonder if it is a good idea to retry responses...

The NCP should retry at the APS/MAC layers - this happens quickly.
If a node has sent a message, and has not received a response within some time (probably in the order of 8 seconds due to sleepy device timing) it will likely give up or resend the request. Either way, it won't then be expecting the response to the original message with the original APS transaction ID. Therefore, re-queuing the response is likely just adding to congestion.

IIRC we already handle DefaultResponses like this - send and forget.

Below is an example - we see transaction 9C being resent much later. Note that this is a filtered log - this is a large network during startup when there is a lot happening (probably too much!).

image

@cdjackson cdjackson added the bug label Jul 19, 2020
@stale
Copy link

stale bot commented Sep 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 17, 2020
@cdjackson cdjackson removed the wontfix label Sep 17, 2020
@stale
Copy link

stale bot commented Nov 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 17, 2020
@cdjackson cdjackson removed the wontfix label Nov 17, 2020
@stale
Copy link

stale bot commented Jan 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 16, 2021
@cdjackson cdjackson added pinned Will not be closed, even if stale and removed wontfix labels Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pinned Will not be closed, even if stale
Projects
None yet
Development

No branches or pull requests

1 participant