Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated cluster attribute read commands #630

Open
cdjackson opened this issue May 14, 2019 · 4 comments
Open

Remove deprecated cluster attribute read commands #630

cdjackson opened this issue May 14, 2019 · 4 comments
Labels
breaking change enhancement pinned Will not be closed, even if stale
Milestone

Comments

@cdjackson
Copy link
Member

As per #591, in 1.3.0 we should remove the deprecated methods that were deprecated in 1.2.0.

@cdjackson cdjackson added this to the 1.3.0 milestone May 14, 2019
@cdjackson cdjackson added the pinned Will not be closed, even if stale label Oct 6, 2019
@cdjackson cdjackson modified the milestones: 1.3.0, 1.4.o, 1.4.0 Nov 14, 2019
@tejas-n
Copy link
Contributor

tejas-n commented Mar 23, 2020

Can I pick this one up or is it planned to be done later? 😄
I'm assuming this has two parts?

  1. Replacing the internal refrences to the deprecated methods and
  2. Modifying the auto encoder to not generate those methods and generate the new cluster classes?

@cdjackson
Copy link
Member Author

Hi Tejas,
I didn't want to do this too soon as I want to avoid breaking users systems :)

That said, if you wanted to pick up point 1 (replace internal references) then that would be great. I did do some, but I don't recall if I systematically went through and removed all internal uses or not. This could certainly be done now if you wanted, and would be appreciated.

The autocoder part is pretty simple since all methods are already marked deprecated, and it's just a case of removing them. I don't really want to do that for a while though as it will break systems that are still using these methods - my plan was to do this shortly before the update from V1.3.x to 1.4.0 which is probably a little way off at the moment.

Is there a reason you wanted to remove them? eg is it causing resource issues in your system?

@tejas-n
Copy link
Contributor

tejas-n commented Mar 23, 2020

Thanks for the reply, Chris.
There's no particular reason I wanted to do it. It's just that I had a bit of free time on the weekend and I saw this issue which I assumed would be easy to do :)
I can certainly pick up point 1, I think I saw a few internal usages.

@cdjackson
Copy link
Member Author

cdjackson commented Mar 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement pinned Will not be closed, even if stale
Projects
None yet
Development

No branches or pull requests

2 participants