Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new option to include assets that aren't in any chunk #204

Closed
martin-eq opened this issue Nov 21, 2019 · 2 comments · Fixed by #264
Closed

Add a new option to include assets that aren't in any chunk #204

martin-eq opened this issue Nov 21, 2019 · 2 comments · Fixed by #264

Comments

@martin-eq
Copy link

martin-eq commented Nov 21, 2019

Is your feature request related to a problem? Please describe.
In our project, we are using the entrypoints option set to true to organize el assets output by entry points so we can load the proper assets for each page. We would like to preload the font assets, which aren't in any chunk due to being imported in scss files. Those assets are part of the "unnamed chunk" which is included in the assets file when entrypoints is false.

Describe the solution you'd like
We would like to include a new option called includeFilesWithoutChunk which is false by default and when set to true, the assets from the "unnamed chunk" would get included in the assets file under a "unnamed key" in the json output.

Describe alternatives you've considered
We haven't think of other alternatives for solving this problem. Suggestions are welcome.

Additional context
We are testing this change on a fork that we included in our project. The code change diff looks like this:
Screen Shot 2019-11-21 at 14 46 54
If this solution is accepted, I can create a PR with this code to this repo.

Thanks!

@catalinux
Copy link

How did you solve this?

@ztoben
Copy link
Owner

ztoben commented Mar 11, 2020

Sorry, must have missed this one. That seems like a reasonable solution, happy to take a look at any PRs @martin-eq!

ztoben added a commit that referenced this issue Sep 22, 2020
Issue #204 Add support for including assets not in any chunk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants