Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auxiliary assets #302

Closed
geldmacher opened this issue Nov 13, 2020 · 4 comments
Closed

Add auxiliary assets #302

geldmacher opened this issue Nov 13, 2020 · 4 comments
Labels
enhancement

Comments

@geldmacher
Copy link
Contributor

geldmacher commented Nov 13, 2020 •
edited

Is your feature request related to a problem? Please describe.
You need this if, for example, a JPG image is included in a CSS file via background-image. This image file is than included in the auxiliary assets for the coresponding chunk.

Describe the solution you'd like
If the option includeAuxiliaryAssets is true (false by default), auxiliary assets are included.

Additional context
I made this patch: https://github.com/geldmacher/assets-webpack-plugin/tree/patch-1
@ztoben
Copy link
Owner

ztoben commented Nov 13, 2020

Looks great, I'll get this merged and push out a new version.

@ztoben ztoben closed this as completed Nov 13, 2020
@ztoben
Copy link
Owner

ztoben commented Nov 13, 2020

This is available in v6.0.4.

@geldmacher
Copy link
Contributor Author

@ztoben My patch introduced a bug.

See: geldmacher@ec4a20e

Fix: https://github.com/geldmacher/assets-webpack-plugin/tree/patch-2

@ztoben
Copy link
Owner

ztoben commented Nov 30, 2020

@geldmacher fix is available in v6.0.5. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geldmacher @ztoben