Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reconnect error page. #862

Open
vsvipul opened this issue Jan 14, 2020 · 24 comments · May be fixed by #1166
Open

Improve reconnect error page. #862

vsvipul opened this issue Jan 14, 2020 · 24 comments · May be fixed by #1166

Comments

@vsvipul
Copy link
Collaborator

vsvipul commented Jan 14, 2020

The visual appearance of the reconnect error page we see when there are problems with the internet connection can be significantly improved.

Screenshot from 2020-01-14 18-48-18

  • Clear steps to reproduce the issue:
    Start the app without an internet connection
@thesmallstar
Copy link

can I work on this?

@vsvipul
Copy link
Collaborator Author

vsvipul commented Jan 21, 2020

@thesmallstar Yes, why not? Work on it, make a PR. Also, attach a screenshot showing what changes you made.

@som23ya
Copy link
Collaborator

som23ya commented Jan 21, 2020

@zulipbot claim --force

@zulipbot
Copy link
Member

Hello @som23ya, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@som23ya
Copy link
Collaborator

som23ya commented Jan 21, 2020

Hey! can i contribute to this?

@iyashwantsaini
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @meyash! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@iyashwantsaini
Copy link
Collaborator

Can i completely change the UI of the network page?

@zulipbot
Copy link
Member

zulipbot commented Mar 15, 2020

Hello @meyash, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

samyakgaur added a commit to samyakgaur/zulip-desktop that referenced this issue Jul 8, 2020
Fixes zulip#862. Center aligned the text and added a table to make points look better.
samyakgaur added a commit to samyakgaur/zulip-desktop that referenced this issue Jul 13, 2020
Fixes zulip#862. Center aligned the text and added a table to make points look better.
samyakgaur added a commit to samyakgaur/zulip-desktop that referenced this issue Jul 13, 2020
Fixes zulip#862. Center aligned the text and added a table to make points look better.
samyakgaur added a commit to samyakgaur/zulip-desktop that referenced this issue Sep 18, 2020
Fixes zulip#862. Center aligned the text and added a table to make points look better.
samyakgaur added a commit to samyakgaur/zulip-desktop that referenced this issue Sep 22, 2020
Fixes zulip#862. Center aligned the text and added a table to make points look better.Div tags are changed to button tag and mobile comptaibility added.
samyakgaur added a commit to samyakgaur/zulip-desktop that referenced this issue Sep 22, 2020
Fixes zulip#862. Center aligned the text and added a table to make points look better.Div tags are changed to button tag and mobile comptaibility added.
@abhi14nexu
Copy link
Collaborator

The reconnect error page still looks the same at this time. Can I work on this issue?

@abhi14nexu
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @abhi14nexu! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@abhi14nexu abhi14nexu removed their assignment Nov 3, 2020
@pranav2012
Copy link

@zulipbot claim

1 similar comment
@Pushpit07
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @Pushpit07! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Mar 27, 2021

Hello @Dishti-Oberai, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@Dishti-Oberai
Copy link
Collaborator

Hi ,
Can I start working on this issue ?
@zulipbot claim

@SidharajYadav

This comment has been minimized.

@enesonus
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

Hello @enesonus!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

enesonus added a commit to enesonus/zulip-desktop that referenced this issue Mar 31, 2023
enesonus added a commit to enesonus/zulip-desktop that referenced this issue Mar 31, 2023
Aveepsita added a commit to Aveepsita/zulip-desktop that referenced this issue Apr 1, 2023
@abhishekcha790
Copy link

@zulipbot hey!! can you assign this issue to me.

@zboutchyard
Copy link

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Aug 4, 2023

Hello @zboutchyard!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@zboutchyard
Copy link

ready to open a PR for this if someone can assign the issue. Looks like the bot spotted a missing tag label for this issue.

enesonus added a commit to enesonus/zulip-desktop that referenced this issue Jan 27, 2024
'texts' div id to 'network-error-texts'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment