Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Windows CI from Appveyor to GitHub Actions #1070

Open
rht opened this issue Jan 19, 2021 · 21 comments · May be fixed by #1350
Open

Migrate Windows CI from Appveyor to GitHub Actions #1070

rht opened this issue Jan 19, 2021 · 21 comments · May be fixed by #1350

Comments

@rht
Copy link

rht commented Jan 19, 2021

We'd want to have fewer CI platforms to keep track of.
See also https://chat.zulip.org/#narrow/stream/16-desktop/topic/appveyor.20ci.

@ganpa3
Copy link
Collaborator

ganpa3 commented Jan 19, 2021

@zulipbot claim

@zulipbot
Copy link
Member

Hello @ganpa3!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@ganpa3
Copy link
Collaborator

ganpa3 commented Jan 19, 2021

Much of the work is done in this PR:
#901

@rht
Copy link
Author

rht commented Jan 19, 2021

@ganpa3 that PR is for app installer. The test procedure on appveyor.yml is different. You can still work on it.

@rht
Copy link
Author

rht commented Jan 19, 2021

Oh, actually, that PR includes npm run test on windows-latest.

@timabbott
Copy link
Sponsor Member

Sounds like we should rebase/clean up #901, which seems to have been unfinished; I don't think the author has been active recently so someone else should take it up.

@ganpa3
Copy link
Collaborator

ganpa3 commented Feb 5, 2021

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 5, 2021

Hello @ganpa3!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@ganpa3
Copy link
Collaborator

ganpa3 commented Feb 5, 2021

@zulipbot add "help wanted"

@ganpa3
Copy link
Collaborator

ganpa3 commented Feb 5, 2021

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 5, 2021

Welcome to Zulip, @ganpa3! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@ganpa3
Copy link
Collaborator

ganpa3 commented Feb 10, 2021

@rht Would you please review the PR #1074 related to this issue?

@zulipbot
Copy link
Member

zulipbot commented Mar 7, 2021

@yaminijha1 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@ganpa3
Copy link
Collaborator

ganpa3 commented Mar 8, 2021

@zulipbot ok

@SidharajYadav

This comment has been minimized.

@yaminijha1
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jan 7, 2024

Welcome to Zulip, @yaminijha1! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@yaminijha1 yaminijha1 linked a pull request Jan 10, 2024 that will close this issue
yaminijha1 added a commit to yaminijha1/zulip-desktop that referenced this issue Jan 10, 2024
Fixes zulip#1070

In this commit I have added build workflow for windows in github
action.
@yaminijha1
Copy link
Collaborator

@zulipbot claim

@yaminijha1
Copy link
Collaborator

@zulipbot @timabbott I have created PR #1350 to fix this issue, Can you please review this PR?

@zulipbot
Copy link
Member

zulipbot commented Jan 25, 2024

@yaminijha1 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@yaminijha1
Copy link
Collaborator

@priyank-p, can you please describe why this issue remains open? Initially, we had Appveyor for Windows, and then I defined a GitHub action for Windows in this PR #1350

If possible can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants