Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

left_sidebar: Rename "more topics" to "show all topics" #30033

Merged
merged 1 commit into from
Jun 4, 2024
Merged

left_sidebar: Rename "more topics" to "show all topics" #30033

merged 1 commit into from
Jun 4, 2024

Conversation

kuv2707
Copy link
Collaborator

@kuv2707 kuv2707 commented May 9, 2024 •
edited

This PR replaces the occurrences of "more topics" to "show all topics" in the UI, comments and documentation.

Fixes #30014

Screenshots and screen captures:

Screenshots

image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: S area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers priority: high labels May 9, 2024
@alya
Copy link
Contributor

alya commented May 14, 2024

We are replacing the /why-zulip screenshot soon, so Iet's skip it for this PR.

@kuv2707
Copy link
Collaborator Author

kuv2707 commented May 16, 2024

@alya Done.

@timabbott
Copy link
Sponsor Member

@kuv2707 can you switch this to "show all topics"? After seeing this, I think that's what we want to test.

@kuv2707
Copy link
Collaborator Author

kuv2707 commented May 17, 2024

@timabbott done.

@kuv2707
Copy link
Collaborator Author

kuv2707 commented Jun 1, 2024

@alya Please have a look.

@alya
Copy link
Contributor

alya commented Jun 3, 2024

@timabbott Do you want to review this directly? I haven't tested.

@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label Jun 3, 2024
@kuv2707 kuv2707 changed the title left_sidebar: Rename "more topics" to "all topics" left_sidebar: Rename "more topics" to "show all topics" Jun 4, 2024
@kuv2707
left_sidebar: Rename "more topics" to "all topics".
f2c1d5a 
This commit renames the occurrences of "more topics"
to "all topics" in comments and documentation.

Fixes zulip#30014
@timabbott timabbott merged commit 2c98263 into zulip:main Jun 4, 2024
14 checks passed
@timabbott
Copy link
Sponsor Member

Looks good to me, merged, thanks @kuv2707!

@kuv2707 kuv2707 deleted the rename_more_topics branch June 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: left sidebar (ui) Left sidebar buttons/interactions excluding popovers integration review Added by maintainers when a PR may be ready for integration. priority: high size: S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "more topics" to "all topics" in left sidebar
4 participants
@kuv2707 @alya @timabbott @zulipbot