Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve onboarding_steps subystem. #30043

Open
2 of 5 tasks
prakhar1144 opened this issue May 10, 2024 · 1 comment
Open
2 of 5 tasks

Improve onboarding_steps subystem. #30043

prakhar1144 opened this issue May 10, 2024 · 1 comment
Assignees
@prakhar1144
Labels
area: onboarding in progress

Comments

@prakhar1144
Copy link
Member

prakhar1144 commented May 10, 2024 •
edited

Follow-ups of #29296 & improvements for onboarding_steps subsystem as a whole:

  • Rename test_hotspots.py to test_onboarding_steps.py
  • Remove tutorial_status field from UserProfile model. -- Fields is no longer used.
  • Remove onboarding_steps field from UserProfile model. -- Fields is no longer used. (b5e22bf)
  • Fix ui_init.js to not store onboarding_steps state data as current_user_params entry & related changes.
  • Update https://zulip.readthedocs.io/en/latest/subsystems/hotspots.html
@prakhar1144 prakhar1144 self-assigned this May 10, 2024
@zulipbot
Copy link
Member

Hello @zulip/server-onboarding members, this issue was labeled with the "area: onboarding" label, so you may want to check it out!

prakhar1144 added a commit to prakhar1144/zulip that referenced this issue May 27, 2024
@prakhar1144
user_profile: Remove 'tutorial_status' field.
695291c 
The 'tutorial_status' field on 'UserProfile' model is
no longer used to show onboarding tutorial.

This commit removes the 'tutorial_status' field and
'needs_tutorial' parameter in 'page_params'.

Fixes part of zulip#30043.
@prakhar1144 prakhar1144 mentioned this issue May 27, 2024
Draft
12 tasks
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue May 27, 2024
@prakhar1144
user_profile: Remove 'tutorial_status' field.
9f46d1f 
The 'tutorial_status' field on 'UserProfile' model is
no longer used to show onboarding tutorial.

This commit removes the 'tutorial_status' field and
'needs_tutorial' parameter in 'page_params'.

Fixes part of zulip#30043.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue May 29, 2024
@prakhar1144
user_profile: Remove 'onboarding_steps' field.
767d560 
Removes the 'onboarding_steps' field on 'UserProfile'
model which is no longer used.

It was introduced back in 2013 (b5e22bf), and is no
longer used.

Fixes part of zulip#30043.
@prakhar1144 prakhar1144 mentioned this issue May 29, 2024
Merged
12 tasks
timabbott pushed a commit that referenced this issue May 29, 2024
@prakhar1144 @timabbott
user_profile: Remove 'onboarding_steps' field.
1ce7c11 
Removes the 'onboarding_steps' field on 'UserProfile'
model which is no longer used.

It was introduced back in 2013 (b5e22bf), and is no
longer used.

Fixes part of #30043.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jun 3, 2024
@prakhar1144
ui_init: Don't store onboarding_steps state_data as current_user_param.
e0bf6c5 
Earlier, onboarding_steps field of state_data was stored as
current_user_params.

Now, we store it separately in a data structure initialized in
onboarding_steps.ts

Reason: All the other state_data fields stored in current_user_params
are attributes of UserProfile. So, it makes sense to store it
separately.

Fixes part of zulip#30043.
timabbott pushed a commit that referenced this issue Jun 3, 2024
@prakhar1144 @timabbott
ui_init: Don't store onboarding_steps state_data as current_user_param.
32391c3 
Earlier, onboarding_steps field of state_data was stored as
current_user_params.

Now, we store it separately in a data structure initialized in
onboarding_steps.ts

Reason: All the other state_data fields stored in current_user_params
are attributes of UserProfile. So, it makes sense to store it
separately.

Fixes part of #30043.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prakhar1144 prakhar1144

Labels
area: onboarding in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alya @zulipbot @prakhar1144