Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert channel warning tooltip to Tippy #30075

Open
alya opened this issue May 13, 2024 · 7 comments · May be fixed by #30175
Open

Convert channel warning tooltip to Tippy #30075

alya opened this issue May 13, 2024 · 7 comments · May be fixed by #30175
Assignees
Labels
area: popovers Popovers, including general message actions. help wanted in progress

Comments

@alya
Copy link
Contributor

alya commented May 13, 2024

When a user is not subscribed to a channel, we show a warning in the typeahead next to the name of that channel.

Screenshot 2024-05-13 at 10 38 45@2x

We should:

  • Convert the tooltip to use Tippy, like other tooltips. It should appear without delay.
  • Remove "currently" from the text, to simplify it slightly.
@alya alya added help wanted area: popovers Popovers, including general message actions. labels May 13, 2024
@alya alya changed the title Convert stream warning tooltip to Tippy Convert channel warning tooltip to Tippy May 13, 2024
@Wislamp
Copy link
Collaborator

Wislamp commented May 13, 2024

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @Wislamp! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

@Mukul1235 This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!

@Mukul1235
Copy link
Collaborator

Hi @Wislamp
Are you still working on this issue?

@Wislamp
Copy link
Collaborator

Wislamp commented May 22, 2024 via email

@Mukul1235
Copy link
Collaborator

ok got it. Let me know if you need any help in this issue. I already resolved this issue on my local.

@Wislamp
Copy link
Collaborator

Wislamp commented May 23, 2024 via email

@Wislamp Wislamp linked a pull request May 23, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: popovers Popovers, including general message actions. help wanted in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants