New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): added parameter 117 to template and to Wave Plug US and UK #6827
Closed
QubinoHelp
wants to merge
18
commits into
zwave-js:master
from
QubinoHelp:import-config-ShellyQubino-00004
Closed
feat(config): added parameter 117 to template and to Wave Plug US and UK #6827
QubinoHelp
wants to merge
18
commits into
zwave-js:master
from
QubinoHelp:import-config-ShellyQubino-00004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM. added wave_template
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM added wave_template
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM added wave_template fixed errors from previous pull request feat(config): added Wave devices zwave-js#6610 Fixes reportd by the lint test
more fixes of the code
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM, 1 Mini, 1PM Mini, PM Mini added wave_template added zwaveAllianceId to Wave 1, Wave 1PM, Wave Plug US, Wave Plug UK, Wave i4, Wave Pro 1, Wave 1PM Mini, Wave 1 Mini change optimise Wave 1, Wave 1PM, Wave 2PM config using template change manufacturer name
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM, 1 Mini, 1PM Mini, PM Mini added wave_template added zwaveAllianceId to Wave 1, Wave 1PM, Wave Plug US, Wave Plug UK, Wave i4, Wave Pro 1, Wave 1PM Mini, Wave 1 Mini change optimise Wave 1, Wave 1PM, Wave 2PM config using template change manufacturer name
add Wave 2PM missing parameters add Wave Plug UK mising parameter fix Wave Pro 1PM fixed name
… UK, added Z-Wave alliance ID for Wave Pro 1PM, fixed alliance ID Wave i4 DC
AlCalzone
changed the title
Feat(config): added parameter 117 to template and to Wave Plug US and UK
feat(config): added parameter 117 to template and to Wave Plug US and UK
May 8, 2024
@QubinoHelp did you close this on purpose? |
@AlCalzone Yes, there was some errors that I couldn't fix, actually it was asking me to correct the lines that I just add.. I didn't know what's going on and was out of time. I will check it today and open a new pool request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat(config): added parameter 117 to template and to Wave Plug US and UK,
added Z-Wave alliance ID for Wave Pro 1PM, fixed alliance ID Wave i4 DC