Deserializer is not maintaining previewFeatures and binaryTargets options
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniravi24
force-pushed
the
fix-client-provider-generation
branch
from
6dab7bc
to
e153b41
Compare
|
@botika sorry to bump you! Wanted to check if you could merge this and do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deserializers aren't accounting for the
previewFeaturesandbinaryTargetsoptions being set, so it never adds them back into the schema if they are present.Also, whenever syncing with the DB, Prisma puts the generators above the datasource, so made a small change to re-order the output to match what Prisma is doing.
fixes #174