Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-cnpg 1.23.1 (new formula) #171980

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

Skaronator
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This is the kubectl plugin for the CloudNativePG Kubernetes Operator: https://github.com/cloudnative-pg/cloudnative-pg

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core autobump labels May 17, 2024
Formula/k/kubectl-cnpg.rb Outdated Show resolved Hide resolved
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@Skaronator Skaronator force-pushed the kubectl-cnpg branch 4 times, most recently from f4b3ae1 to 781aff0 Compare May 17, 2024 16:29
@Skaronator Skaronator marked this pull request as draft May 17, 2024 16:41
@Skaronator Skaronator marked this pull request as ready for review May 17, 2024 17:07
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few comments.

Formula/k/kubectl-cnpg.rb Outdated Show resolved Hide resolved
Formula/k/kubectl-cnpg.rb Outdated Show resolved Hide resolved
Formula/k/kubectl-cnpg.rb Outdated Show resolved Hide resolved
@Skaronator Skaronator marked this pull request as draft May 18, 2024 11:47
@Skaronator Skaronator marked this pull request as ready for review May 18, 2024 12:50
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label May 18, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 18, 2024
Merged via the queue into Homebrew:master with commit a72d2ed May 18, 2024
14 checks passed
@Skaronator Skaronator deleted the kubectl-cnpg branch May 18, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants