Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop silent mode as no performance benefit #1104

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

eagleoflqj
Copy link
Contributor

The option is undocumented so users shouldn'b be affected.

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
css-render ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 4:01pm

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.45 🎉

Comparison is base (8f14fd1) 89.09% compared to head (faa3516) 91.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
+ Coverage   89.09%   91.55%   +2.45%     
==========================================
  Files          10       10              
  Lines         321      296      -25     
  Branches       95       85      -10     
==========================================
- Hits          286      271      -15     
+ Misses         15       10       -5     
+ Partials       20       15       -5     
Flag Coverage Δ
css-render 91.58% <100.00%> (+3.30%) ⬆️
plugin-bem 100.00% <ø> (ø)
vue3-ssr 69.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/css-render/src/CssRender.ts 85.71% <ø> (+7.14%) ⬆️
packages/css-render/src/mount.ts 87.17% <ø> (+5.54%) ⬆️
packages/css-render/src/c.ts 100.00% <100.00%> (ø)
packages/css-render/src/render.ts 90.69% <100.00%> (+3.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@07akioni 07akioni merged commit 1a07cba into 07akioni:master Apr 23, 2023
5 checks passed
@eagleoflqj eagleoflqj deleted the drop-slient branch April 23, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants