Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mount at shadow root #1105

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Support mount at shadow root #1105

merged 1 commit into from
Jun 19, 2023

Conversation

eagleoflqj
Copy link
Contributor

Fixes #689
Add a parent parameter to mount and unmount, which falls back to document.head when absent.

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
css-render ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 2:01pm

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (794d6ac) 91.55% compared to head (d313f83) 91.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   91.55%   91.61%   +0.05%     
==========================================
  Files          10       10              
  Lines         296      298       +2     
  Branches       85       87       +2     
==========================================
+ Hits          271      273       +2     
  Misses         10       10              
  Partials       15       15              
Flag Coverage Δ
css-render 91.66% <100.00%> (+0.07%) ⬆️
plugin-bem 100.00% <ø> (ø)
vue3-ssr 69.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/css-render/src/c.ts 100.00% <100.00%> (ø)
packages/css-render/src/mount.ts 87.80% <100.00%> (+0.62%) ⬆️
packages/css-render/src/utils.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@07akioni 07akioni merged commit 316c808 into 07akioni:master Jun 19, 2023
5 checks passed
@eagleoflqj eagleoflqj deleted the shadow branch June 19, 2023 15:57
@mttzzz
Copy link

mttzzz commented Mar 26, 2024

Hello @07akioni !! Could you please kindly review and expedite the approval of this pull request at your earliest convenience? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShadowDom Support
3 participants