Factory initialization directly with Renderer #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor comment: Can you fix the typo in the second commit message? Do you have a small-ish example of using this new API? Either a JSFiddle or a snippet of code from a website you're building would help. Thanks! |
The `renderer` field of `FactoryOptions` was changed to also be an instance of `Renderer` via an union. The other way of initializing a `Factory` remains unaffected. A test-case had to be slightly modified since it didn't account for the union I created. This fixes 0xfe#580 since an instance of `Renderer` can be created with DOM elements and `Factory` can now be created with an instance of `Renderer`.
|
Fixed the typo. I'll also try to do an example next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes to
Factorysuch thatFactoryOptionscan now accept an instance ofRenderer.This fixes #580.