[FEATURE] Créer le composant Pix Toast (PIX-9580). #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiaPena
changed the title
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr482.review.pix.fr |
AndreiaPena
force-pushed
the
pix-9580-add-pix-toaster-component
branch
from
a22e38f
to
8cc678a
Compare
|
Je pense qu'on dit plutôt un composant Toast plutôt que Toaster :) |
J'ai suivi aveuglement le DS mais effectivement, en regardant ailleurs on dit bien Toast :o je change ça et j'en parle aux ui/ux |
AndreiaPena
force-pushed
the
pix-9580-add-pix-toaster-component
branch
from
8cc678a
to
2bb74cd
Compare
AndreiaPena
changed the title
AndreiaPena
force-pushed
the
pix-9580-add-pix-toaster-component
branch
5 times, most recently
from
f1fe268
to
03979ab
Compare
AndreiaPena
force-pushed
the
pix-9580-add-pix-toaster-component
branch
10 times, most recently
from
793e629
to
5438da1
Compare
AndreiaPena
force-pushed
the
pix-9580-add-pix-toaster-component
branch
from
5438da1
to
f8d575f
Compare
AndreiaPena
force-pushed
the
pix-9580-add-pix-toaster-component
branch
from
f8d575f
to
0f382a6
Compare
mcampourcy
approved these changes
Jan 30, 2024
|
On en fait quoi ? |
Il faudrait qu'on le poursuive mais je galère un peu à créer le service. J'aurais besoin d'aide pour le continuer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Actuellement, nos applications Pix n'ont pas le même design sur les notifications. Si on se réfère au design system, on devrait avoir un composant Pix Toast permettant à nos apps d'être iso (+ avoir des notifs accessible)
Coté Orga : (proche du design system, + travail sur l'a11y) :
Coté Admin et Certif : (version de base) :
🎁 Proposition
Créer le composant Pix Toast
🌟 Remarques
🎅 Pour tester