-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Ajouter la page de modification d'infos et référentiel d'un profil cible (PIX-12442). #8850
Open
Jeyffrey
wants to merge
4
commits into
dev
Choose a base branch
from
pix-12442-add-target-profile-update-page
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyffrey
added
👀 Tech Review Needed
👀 Func Review Needed
team-evaluation
PR relatives à l'expérience d'évaluation
labels
May 6, 2024
Jeyffrey
changed the base branch from
dev
to
pix-12436-add-target-profile-tubes-update
May 6, 2024 13:37
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
from
May 6, 2024 13:38
153be65
to
89240a8
Compare
Jeyffrey
force-pushed
the
pix-12436-add-target-profile-tubes-update
branch
from
May 6, 2024 15:21
5801346
to
62d9dc5
Compare
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
from
May 6, 2024 15:24
89240a8
to
14a0e5b
Compare
Jeyffrey
force-pushed
the
pix-12436-add-target-profile-tubes-update
branch
from
May 6, 2024 15:24
62d9dc5
to
9eacc6f
Compare
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
from
May 6, 2024 15:25
14a0e5b
to
28ef2a6
Compare
Jeyffrey
force-pushed
the
pix-12436-add-target-profile-tubes-update
branch
2 times, most recently
from
May 7, 2024 15:58
d67ea8e
to
2435843
Compare
Jeyffrey
force-pushed
the
pix-12436-add-target-profile-tubes-update
branch
11 times, most recently
from
May 24, 2024 08:54
978d7bf
to
473b03d
Compare
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
2 times, most recently
from
May 24, 2024 09:45
fcf1ad5
to
9085a59
Compare
Jeyffrey
force-pushed
the
pix-12436-add-target-profile-tubes-update
branch
from
May 28, 2024 13:08
473b03d
to
ee404ad
Compare
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
from
May 28, 2024 13:14
9085a59
to
2fdc2f8
Compare
pix-service-auto-merge
force-pushed
the
pix-12436-add-target-profile-tubes-update
branch
3 times, most recently
from
May 30, 2024 08:14
c9cc234
to
c062d64
Compare
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
4 times, most recently
from
May 31, 2024 13:13
bed6e23
to
bc71fde
Compare
Jeyffrey
force-pushed
the
pix-12442-add-target-profile-update-page
branch
from
June 4, 2024 12:52
bc71fde
to
7418f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite de la PR API : #8842
🦄 Problème
Nous avons l'objectif de rendre possible la duplication d'un profil cible existant en autorisant la modification de son référentiel.
Or, à l'heure actuelle, il n'est pas permis de modifier ce référentiel.
🤖 Proposition
Autoriser la modification d'un profil cible lorsque celui-ci n'est pas encore relié à une campagne.
Pour ce faire, la modification du profil cible a été repensée :
ℹ️ Remarques
Le fichier
CreateTargetProfileForm
a été renomméEditTargetProfileForm
pour convenir à le fois à la création et à la modification du profil cible.💯 Pour tester
Aussi : pour un profil cible relié à une campagne, cliquer sur "Modifier" et constater qu'on ne propose pas la modification du référentiel.