Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ajouter la page de modification d'infos et référentiel d'un profil cible (PIX-12442). #8850

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Jeyffrey
Copy link
Contributor

@Jeyffrey Jeyffrey commented May 6, 2024

Suite de la PR API : #8842


🦄 Problème

Nous avons l'objectif de rendre possible la duplication d'un profil cible existant en autorisant la modification de son référentiel.

Or, à l'heure actuelle, il n'est pas permis de modifier ce référentiel.

🤖 Proposition

Autoriser la modification d'un profil cible lorsque celui-ci n'est pas encore relié à une campagne.

Pour ce faire, la modification du profil cible a été repensée :

Lorsqu'on clique sur "Modifier", on atterrit maintenant sur une nouvelle page /edit permettant la modification.

  1. Si on est pas encore relié à une campagne : on peut modifier le référentiel
  2. Si on est relié à une campagne : on ne peut pas modifier le référentiel.

ℹ️ Remarques

Le fichier CreateTargetProfileForm a été renommé EditTargetProfileForm pour convenir à le fois à la création et à la modification du profil cible.

💯 Pour tester

  1. Créer un nouveau profil cible puis cliquer sur "Modifier".
  2. Changer des infos et le référentiel.
  3. Constater que la modification fonctionne comme souhaité.

Aussi : pour un profil cible relié à une campagne, cliquer sur "Modifier" et constater qu'on ne propose pas la modification du référentiel.

@Jeyffrey Jeyffrey self-assigned this May 6, 2024
@Jeyffrey Jeyffrey changed the base branch from dev to pix-12436-add-target-profile-tubes-update May 6, 2024 13:37
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch from 153be65 to 89240a8 Compare May 6, 2024 13:38
@Jeyffrey Jeyffrey marked this pull request as draft May 6, 2024 13:46
@Jeyffrey Jeyffrey force-pushed the pix-12436-add-target-profile-tubes-update branch from 5801346 to 62d9dc5 Compare May 6, 2024 15:21
@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch from 89240a8 to 14a0e5b Compare May 6, 2024 15:24
@Jeyffrey Jeyffrey force-pushed the pix-12436-add-target-profile-tubes-update branch from 62d9dc5 to 9eacc6f Compare May 6, 2024 15:24
@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch from 14a0e5b to 28ef2a6 Compare May 6, 2024 15:25
@Jeyffrey Jeyffrey force-pushed the pix-12436-add-target-profile-tubes-update branch 2 times, most recently from d67ea8e to 2435843 Compare May 7, 2024 15:58
@Jeyffrey Jeyffrey force-pushed the pix-12436-add-target-profile-tubes-update branch 11 times, most recently from 978d7bf to 473b03d Compare May 24, 2024 08:54
@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch 2 times, most recently from fcf1ad5 to 9085a59 Compare May 24, 2024 09:45
@Jeyffrey Jeyffrey closed this May 27, 2024
@Jeyffrey Jeyffrey reopened this May 27, 2024
@Jeyffrey Jeyffrey closed this May 28, 2024
@Jeyffrey Jeyffrey reopened this May 28, 2024
@Jeyffrey Jeyffrey marked this pull request as ready for review May 28, 2024 09:24
@Jeyffrey Jeyffrey closed this May 28, 2024
@Jeyffrey Jeyffrey reopened this May 28, 2024
@Jeyffrey Jeyffrey force-pushed the pix-12436-add-target-profile-tubes-update branch from 473b03d to ee404ad Compare May 28, 2024 13:08
@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch from 9085a59 to 2fdc2f8 Compare May 28, 2024 13:14
@Jeyffrey Jeyffrey closed this May 28, 2024
@Jeyffrey Jeyffrey reopened this May 28, 2024
@1024pix 1024pix deleted a comment from pix-bot-github May 28, 2024
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-12436-add-target-profile-tubes-update branch 3 times, most recently from c9cc234 to c062d64 Compare May 30, 2024 08:14
Base automatically changed from pix-12436-add-target-profile-tubes-update to dev May 30, 2024 08:20
@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch 4 times, most recently from bed6e23 to bc71fde Compare May 31, 2024 13:13
@Jeyffrey Jeyffrey force-pushed the pix-12442-add-target-profile-update-page branch from bc71fde to 7418f32 Compare June 4, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants