[TECH] sépare le usecase de remplacement des learner (Pix-12529) #8931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
reviewed
May 16, 2024
| i18n: request.i18n, | ||
| }); | ||
| await usecases.validateSupCsvFile({ | ||
| organizationId, | ||
| i18n: request.i18n, | ||
| }); | ||
| warnings = await usecases.importSupOrganizationLearners({ |
There was a problem hiding this comment.
suggestion au début j'ai fait euuuuuuuu pourquoi. avant de me dire mais oui c'est stocker dans organization-import maintenant.
Note pour le suivant qui se posera la questiuon
xav-car
reviewed
May 16, 2024
| @@ -81,9 +80,7 @@ const replaceSupOrganizationLearners = async function ( | |||
| } | |||
| } | |||
|
|
|||
| return h | |||
| .response(dependencies.supOrganizationLearnerWarningSerializer.serialize({ id: organizationId, warnings })) | |||
There was a problem hiding this comment.
supprimer l'import / dependencies maintenant :)
lionelB
force-pushed
the
pix-12529/split-replace-sup-learner
branch
from
e4ce249
to
c1057f2
Compare
xav-car
added
Func Review OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
On souhaite passer l'import du sup en asynchrone, pour cela, on doit découper le usecase en 3 partie (envoi / validation / import) afin de pouvoir ensuite en faire des taches asynchrone pour pgboss
🤖 Proposition
On split le gros usecase en réutilisant les usecases déjà utilisés pour l'import sup
🌈 Remarques
On profite de la PR pour mieux gérer les warning qu'on avait un peu passé rapidement
💯 Pour tester
importer