Skip to content

Commit

Permalink
[breaking] Bump Node minimum to 14. Fixes #2336
Browse files Browse the repository at this point in the history
  • Loading branch information
zachleat committed May 4, 2022
1 parent c3e7fe6 commit eec1482
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
node: ["12", "14", "16"]
node: ["14", "16", "18"]
name: Node.js ${{ matrix.node }} on ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12
14
7 changes: 6 additions & 1 deletion docs/meta-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@ Unfortunate thing about npm: if you push a 1.0.0-canary.x to `canary` after a `2
1. update minor dependencies in package.json? `npm outdated` `npm update --save`
1. npmclean aka `rm -rf node_modules && rm -f package-lock.json && npm install`
1. If the minimum Node version changed, make sure you update `package.json` engines property.
1. Bonus: make sure the error message works correctly for Node versions less than 10. 0.12.x+ requires Node 10+. 1.x+ requires Node 12+
1. Bonus: make sure the error message works correctly for Node versions less than 10.

- 0.12.x+ requires Node 10+
- 1.x+ requires Node 12+
- 2.x+ requires Node 14+

1. `npm run package` to generate a new Eleventy Edge lib
1. npm audit
1. Make sure `npx ava` runs okay
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"license": "MIT",
"engines": {
"node": ">=12"
"node": ">=14"
},
"funding": {
"type": "opencollective",
Expand Down

0 comments on commit eec1482

Please sign in to comment.