Updates #1698 to defer to approach from #2208

11ty · May 11, 2022 · ff6bd8d · ff6bd8d
1 parent 2dc653a
commit ff6bd8d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/src/Plugins/Pagination.js b/src/Plugins/Pagination.js
@@ -195,7 +195,7 @@ class Pagination {
 
     const chunks = lodashChunk(this.target, this.size);
 
-    if (this.data.pagination && this.data.pagination.renderEmpty) {
+    if (this.data.pagination && this.data.pagination.generatePageOnEmptyData) {
       return chunks.length ? chunks : [[]];
     } else {
       return chunks;
@@ -337,11 +337,7 @@ class Pagination {
     // so that we don’t have the memory cost of the full template (and can reuse the parent
     // template for some things)
 
-    for (
-      let pageNumber = 0;
-      pageNumber < items.length;
-      pageNumber++
-    ) {
+    for (let pageNumber = 0; pageNumber < items.length; pageNumber++) {
       let cloned = this.template.clone();
 
       if (pageNumber > 0 && !hasPermalinkField && !hasComputedPermalinkField) {

diff --git a/test/PaginationTest.js b/test/PaginationTest.js
@@ -64,7 +64,7 @@ test("Empty paged data", async (t) => {
   t.is((await paging.getPageTemplates()).length, 0);
 });
 
-test("Empty paged data with pageOnEmptyData enabled", async (t) => {
+test("Empty paged data with generatePageOnEmptyData enabled", async (t) => {
   let eleventyConfig = new TemplateConfig();
   let tmpl = getNewTemplate(
     "./test/stubs/paged/paged-empty-pageonemptydata.njk",
@@ -79,8 +79,8 @@ test("Empty paged data with pageOnEmptyData enabled", async (t) => {
   let paging = new Pagination(data, tmpl.config);
   paging.setTemplate(tmpl);
 
-  t.is(paging.getPageCount(), 0);
-  t.is(paging.pagedItems.length, 0);
+  t.is(paging.getPageCount(), 1);
+  t.is(paging.pagedItems.length, 1);
   t.is((await paging.getPageTemplates()).length, 1);
 });
 

diff --git a/test/stubs/paged/paged-empty-pageonemptydata.njk b/test/stubs/paged/paged-empty-pageonemptydata.njk
@@ -2,7 +2,7 @@
 pagination:
   data: items
   size: 1
-  pageOnEmptyData: true
+  generatePageOnEmptyData: true
 items: []
 ---
 <ol>{% for item in pagination.items %}<li>{{ item }}</li>{% endfor %}</ol>